Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Apify to parse Instagram URLs #485

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Oct 24, 2024

Description

We currently use Apify to parse facebook URLs. In this PR, we are adding the functionality to parse Instagram URLs too using Apify.

References: CV2-4289

Implementation Plan

  • Update MediaApifyItem to accept instagram URLs as well
  • Change the current Instagram parser to call MediaApifyItem
  • Update existing tests with expected Apify JSON schema

How has this been tested?

  • Ensured that all instagram URLs for posts and profiles can be parsed
  • Existing tests are not broken

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

`MediaApifyItem` is currently used to parse facebook URLs. We would like to extend it to parse instagram URLs as well.
Refactor MediaApifyItem to reduce code complexity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant