Initial Splitting of 39/64kWh Niro/Soul/Kona with separated pid_inits #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2024 12:37
…they aren't as big as you wish they were
But would you allow the user to change in without manually changing the profile? I think a good way to do this is by loading the PIDs from the profile into the HTML page to allow manually modifications. |
|
Actually, thought of something like that the other day: Buttons "Load from Profile" "Save to Profile 'name' " and an editor underneath something in the likes of this, would make editing a breeze, along with a "revert to defaults" that would load the profile set from the FW baked json... etc... |
|
Yeah it will be something like that. It's going to be a while before I get to do it, I have other features still pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glad to see pid_init can be for each pid
It could be grouped be pid_init though, and each PID could deserve a separate cycle time, but I imagine it would involve a large overhaul of task management