Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason for new lines at end of files #96

Closed
wants to merge 1 commit into from
Closed

Add reason for new lines at end of files #96

wants to merge 1 commit into from

Conversation

ESWAT
Copy link

@ESWAT ESWAT commented May 13, 2014

Fixes #93. Links to this article to explain why it should be done, specifically for JS files.

@zatkin
Copy link

zatkin commented Jun 16, 2014

This has to do with a system distinguishing between text files (containing "lines") and binary files (which typically don't contain "lines").

More here: http://markmail.org/message/5jsn4epq7ad3vyvt

@zackdouglas
Copy link

This is my reasoning:
https://gist.github.com/zackdouglas/0d4ce1a755e683332c64/revisions

If a newline is added, it is immediately clear that no existing logic is changed simply by adding logic.

@ESWAT ESWAT closed this Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reason for new lines at end of files
3 participants