Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): fix iframe title + div ids #11344

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(build): fix iframe title + div ids #11344

wants to merge 5 commits into from

Commits on Jun 20, 2024

  1. fix(build): fix iframe title and height + div ids 

    - Don't mututate the DOM in collectClosestCode. We'll use the
  same title as with regual live samples.
- Strip suffix from iframe height height="400px" => height="400".
- Don't add ids to divs?! Currnet we add ids to notes by accident:
  https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout/Masonry_layout#sect1
    @fiji-flo
    fiji-flo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    63c6e80 View commit details
    Browse the repository at this point in the history

  2. feedback

    @fiji-flo
    fiji-flo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    05087ba View commit details
    Browse the repository at this point in the history

  3. fix test

    @fiji-flo
    fiji-flo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    80b5875 View commit details
    Browse the repository at this point in the history

  4. fix test

    @fiji-flo
    fiji-flo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7f40c69 View commit details
    Browse the repository at this point in the history

  5. more div -> section

    @fiji-flo
    fiji-flo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4951aa0 View commit details
    Browse the repository at this point in the history