Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for few compilation warnings and checkpatch errors. #177

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shijujose4
Copy link
Contributor

Fix for few compilation warnings and checkpatch errors.

Fix for following compilation warning,
ras-memory-failure-handler.c:120:6: warning: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Wimplicit-function-declaration]
  if (asprintf(&env[ei++], "PATH=%s", getenv("PATH") ?: "/sbin:/usr/sbin:/bin:/usr/bin") < 0)

Signed-off-by: Shiju Jose <[email protected]>
Removed unused definition for RB_ROOT from rbtree.h

Signed-off-by: Shiju Jose <[email protected]>
Fix following checkpatch error in  ras-mce-handler.c

Delete below obselte code under #if 0 ... #endif
WARNING: Consider removing the code enclosed by this #if 0 and its #endif

WARNING: Consider removing the code enclosed by this #if 0 and its #endif

Signed-off-by: Shiju Jose <[email protected]>
Remove unused code enclosed under #if 0 to fix the checkpatch
warnings.

Signed-off-by: Shiju Jose <[email protected]>
… columns

Fix following checkpatch warning in ras-arm-handler.
+			trace_seq_printf(s, " Program execution can be restarted reliably at the PC associated with the error");

Signed-off-by: Shiju Jose <[email protected]>
…not used

Fix following compilation warning,
ras-events.c:318:12: warning: ‘filter_ras_mc_event’ defined but not used [-Wunused-function]
 static int filter_ras_mc_event(struct ras_events *ras, char *group, char *event,

Signed-off-by: Shiju Jose <[email protected]>
Fix following checkpatch warning,
CHECK: spaces preferred around that '*' (ctx:WxV)
+	sqlite3_stmt	*stmt_dec_record;

Signed-off-by: Shiju Jose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant