Tidy initial config file generation / templating #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_config.sh script and into a text file; do some simple templating using sed to allow sensible defaults to be set for hostname, lat/long, etc.
|
I only discovered BirdNET-Pi today, but I was confused when I started browsing through the settings to see that the default model was the one that seemed to exist only for legacy compatibility. I switched to the new one, but I did sort of wonder if I was making a mistake, since I would have expected it to be the default if it were the correct one to use in most cases, especially new installs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the currently used template for new config files out of
install_config.shscript and into a text file, and does some simple templating using sed to allow sensible defaults to be set for hostname, lat/long, etc.I note there was already a "birdnet-defaults.conf" in the root, but it seems to have slightly different default settings in it compared to the 'here document' in
install_config.sh; in particular the default model is different. My suspicion is the default should beBirdNET_GLOBAL_6K_V2.4_Model_FP16, but I will let someone who is more familiar with the codebase reconcile the differences, for the moment I have gone with not changing the current behaviour. For the moment this patch renames the old file to reduce confusion.(This is very much just a tidy-up, it's not a dependency for anything else I'm working on, low priority for review/merge but also hopefully helpful and fairly straightforward.)