Do not save session on client error #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -250,6 +250,7 @@ where | |||
|
|
|||
| _ if (modified || session_config.always_save) | |||
| && !empty | |||
| && !res.status().is_client_error() | |||
There was a problem hiding this comment.
Can you go into more detail regarding the logic here? Django only filters out server errors.
There was a problem hiding this comment.
I've updated PR description. Sorry for the mess.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 83.80% 83.85% +0.04%
==========================================
Files 5 5
Lines 352 353 +1
==========================================
+ Hits 295 296 +1
Misses 57 57 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO, session should not be saved on client error. For instance, with
always_saveoption it can lead to prolonging session lifetime on HTTP 401.Maybe I'm wrong, but in general it seems weird to save session even when client made an invalid request.
But perhaps it would be better not to save on client error, but only when the session was not modified anyway, like so:
?
Or maybe we should just stick to the Django way you showed in #220 (comment) and close this PR?