action: remove max speed settings #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
previously approved these changes
Oct 28, 2024
julianoes
force-pushed
the
pr-remove-max-speed-setting
branch
from
7b951bc
to
b97b0b8
Compare
This API is confusing as it only works for PX4 quads but not PX4 fixedwing or anything ArduPilot based. The reason is that this just sets a PX4 parameter that is not standardized via MAVLink. Therefore, I suggest to remove the API and instead recommend to use the param plugin to set the specific params specifically.
julianoes
force-pushed
the
pr-remove-max-speed-setting
branch
from
b97b0b8
to
a3e5d73
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is confusing as it only works for PX4 quads but not PX4 fixedwing or anything ArduPilot based.
The reason is that this just sets a PX4 parameter that is not standardized via MAVLink.
Therefore, I suggest to remove the API and instead recommend to use the param plugin to set the specific params specifically.
Depends on mavlink/MAVSDK-Proto#355.
Closes #2137.