Update gimbal_full_control.cpp example #2384
Merged
+42
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `gimbal_id` parameter to all gimbal related methods. - Replaced the non-existing `set_mode` method with the `set_angles` method. - Revised `set_angle` methods to include the correct parameters
julianoes
previously approved these changes
Aug 28, 2024
JonasVautherin
previously approved these changes
Aug 29, 2024
|
@JonasVautherin I couldn't figure out the style issue from the logs. Could you please let me know how to fix this locally? |
|
I think you have to run |
KarthiAru
dismissed stale reviews from JonasVautherin and julianoes
via
17ad3a8
|
@JonasVautherin Thanks. I've fixed the style on Ubuntu 24.04 |
|
JonasVautherin
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gimbal_idparameter to all gimbal related methods.set_modemethod with theset_anglesmethod.set_anglemethods to include the correct parameters