Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FTP file descriptor leak #2112

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix FTP file descriptor leak #2112

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88850aa
Address FTP file descriptor leak as described in issue #2108
Zhumos Aug 9, 2023
ec11520
Fix style
Zhumos Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/mavsdk/core/mavlink_ftp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,11 @@ MavlinkFtp::ServerResult MavlinkFtp::_work_list(PayloadHeader* payload, bool lis
memcpy(&payload->data[offset], entry_s.c_str(), len);
offset += len;
}

if (const int close_result = closedir(dfd); close_result != 0) {
LogWarn() << "FTP: Failed to close file descriptor (potential resource leak!). "
"Error code: " << close_result;
}
}

payload->size = offset;
Expand Down
Loading