Address FTP file descriptor leak as described in issue #2108

mavlink · Aug 11, 2023 · 88850aa · 88850aa
1 parent a14d604
commit 88850aa
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/mavsdk/core/mavlink_ftp.cpp b/src/mavsdk/core/mavlink_ftp.cpp
@@ -1027,6 +1027,11 @@ MavlinkFtp::ServerResult MavlinkFtp::_work_list(PayloadHeader* payload, bool lis
             memcpy(&payload->data[offset], entry_s.c_str(), len);
             offset += len;
         }
+
+        if (const int close_result = closedir(dfd); close_result != 0) {
+            LogWarn() << "FTP: Failed to close file descriptor (potential resource leak!). "
+                         "Error code: " << close_result;
+        }
     }
 
     payload->size = offset;