Adds documentation for mautic/mautic/pull/14100 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCheesley
requested changes
Nov 3, 2024
There was a problem hiding this comment.
Thanks for the PR @putzwasser - you need to use the command make link to create the link file and commit it, then you can use the xref macro where the link is.
I've also made a Vale suggestion for the passive to active speech warning which will need implementing anywhere you've used it, please. Thanks!
| @@ -88,9 +88,9 @@ To add a new field to your Form: | |||
| .. note:: | |||
| You can associate checkbox group fields with *boolean* and *select - multiple* fields, but not *select* fields. | |||
|
|
|||
| - **Date** - This field allows the visitor to select a date with a calendar picker. The formatting of the date applies the default setting in your Configuration. | |||
| - **Date** - This field allows the visitor to select a date with a calendar picker. The formatting of the date applies the default setting in your Configuration. [A PHP parseable BNF-like string](https://www.php.net/manual/en/datetime.formats.php) can be used to set a dynamic/relative to now default value for this field. | |||
There was a problem hiding this comment.
Hi @putzwasser please use the command make link at the terminal, follow the steps and then use the xref macro here. For info, if you're doing internal linking check the docs on using the :ref: role for linking within the same document, and using :doc: to link across pages.
Please fix this in all the places you've mentioned it. Thanks!
| @@ -88,9 +88,9 @@ To add a new field to your Form: | |||
| .. note:: | |||
| You can associate checkbox group fields with *boolean* and *select - multiple* fields, but not *select* fields. | |||
|
|
|||
| - **Date** - This field allows the visitor to select a date with a calendar picker. The formatting of the date applies the default setting in your Configuration. | |||
| - **Date** - This field allows the visitor to select a date with a calendar picker. The formatting of the date applies the default setting in your Configuration. [A PHP parseable BNF-like string](https://www.php.net/manual/en/datetime.formats.php) can be used to set a dynamic/relative to now default value for this field. | |||
There was a problem hiding this comment.
Suggested change
| - **Date** - This field allows the visitor to select a date with a calendar picker. The formatting of the date applies the default setting in your Configuration. [A PHP parseable BNF-like string](https://www.php.net/manual/en/datetime.formats.php) can be used to set a dynamic/relative to now default value for this field. | |
| - **Date** - This field allows the visitor to select a date with a calendar picker. The formatting of the date applies the default setting in your Configuration. You can use [A PHP parseable BNF-like string](https://www.php.net/manual/en/datetime.formats.php) to set a dynamic/relative to now default value for this field. |
Passive -> Active voice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for PR mautic/mautic#14100