Tracking links in Emails: Do not track hint #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
previously approved these changes
Jul 22, 2024
|
I think the changes I just committed should fix the Vale warnings. There were a couple of things - inline code blocks need a double backtick to encase them and I think you had too many spaces in the code block indentation - I just used VSCode and hit return on the end of the code block annotation to find out what it was expecting. Also changed 'disabled' to 'turn off' as we're trying to move towards more inclusive language. Thanks for the PR @heebinho 🚀 |
RCheesley
approved these changes
Jul 22, 2024
|
@all-contributors please add @heebinho for docs |
|
I've put up a pull request to add @heebinho! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@escopecz pointed me to this hidden gem. I think this could be a worthy inclusion.