Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded version guard and bump deps #179

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

quangIO
Copy link

@quangIO quangIO commented Jun 19, 2024

This PR removes the version guard in wasmtime and bumps some dependencies.

@quangIO quangIO marked this pull request as draft June 20, 2024 02:49
@quangIO quangIO marked this pull request as ready for review June 20, 2024 02:56
@sandhose
Copy link
Member

As this is a library and not an app, I'm trying to get the dependencies requirements as loose as possible.

This means that for most of them, I'm specifying the minimal version at which the dependency works, and the semver semantics will usually choose the latest version. For example, tokio is set to 1.5, but this will happily use version 1.39.0, but it won't match if tokio ever publishes a 2.0.0

This is the same for wasmtime, but I can't say 'any version more than X', because they are doing major versions regularly with no semver guarantees. This is why I rely on dependabot updates to keep the version guard up to date, but I'm sometimes failing to find the time to do so 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants