Session verification request support #4153
Conversation
… of direct to_device events.
…cation updates before actually accepting one - allows handling remote cancellations on verification requests that have not yet been accepted
…ificationRequestState::Requested`
- the tests used to incorrectly wrap the to-device content into an event as if it was sent by alice instead of bob
| pub async fn is_verified(&self) -> Result<bool, ClientError> { | ||
| let device = | ||
| self.encryption.get_own_device().await?.context("Our own device is missing")?; | ||
| pub fn set_delegate(&self, delegate: Option<Box<dyn SessionVerificationControllerDelegate>>) { |
There was a problem hiding this comment.
I considered switching away from a delegate and towards a listener but the public api changes are so small that I don't really thing it's worth it at this point. Let's reassess when we start thinking about user verification.
| /// request. | ||
| other_device_id: OwnedDeviceId, | ||
| other_device_data: DeviceData, |
There was a problem hiding this comment.
@poljar We initially agreed to pass this DeviceData down into the Transitioned state but I couldn't identify were that would be useful 🤔
|
Please double check the commit messages, I tried making them fit the new contributing guidelines but not sure I nailed it. |
… the final client
…in `VerificationRequestState::Requested`
| pub async fn acknowledge_verification_request( | ||
| &self, | ||
| sender_id: String, | ||
| flow_id: String, |
There was a problem hiding this comment.
Just a quick question regarding API usage: the flow_id is not enough here? We need to also provide the sender_id? (I believe that those data are coming from SessionVerificationRequestDetails).
This PR introduced FFI level API support for interacting with incoming session verification requests. Best reviewed commit by commit
did_receive_verification_requestSessionVerificationControllerdelegate method that includes information about the incoming request/device/senderacknowledge_verification_requestto get informed about it getting accepted somewhere else or cancelledaccept_verification_requestto start interacting with itThis PR also internally switches to the
VerificationRequest::changespublisher, fixes a couple of invalid VerificationMachine tests and starts storing requestingDeviceDatadirectly inVerificationRequestState. RequestedRelates to element-hq/element-meta/issues/2464, fixes #3595.