Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ffi): Merge export and export_async attribute macros #4118

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Oct 10, 2024

I decided to make this forwards-compatible with async fn in callback interfaces / traits, bc. why not?

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (41a2ad0) to head (c13dade).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4118   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files         269      269           
  Lines       28816    28816           
=======================================
+ Hits        24406    24407    +1     
+ Misses       4410     4409    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte marked this pull request as ready for review October 10, 2024 19:40
@jplatte jplatte requested a review from a team as a code owner October 10, 2024 19:40
@jplatte jplatte requested review from jmartinesp and removed request for a team October 10, 2024 19:40
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@bnjbvr bnjbvr removed the request for review from jmartinesp October 11, 2024 07:57
@bnjbvr bnjbvr merged commit e46e637 into main Oct 11, 2024
78 checks passed
@bnjbvr bnjbvr deleted the jplatte/merge-export-macros branch October 11, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants