crypto: Sort IdentityStatusChanges when providing them via subscribe_to_identity_status_changes #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4114 +/- ##
==========================================
- Coverage 84.69% 84.68% -0.01%
==========================================
Files 269 269
Lines 28816 28818 +2
==========================================
Hits 24405 24405
- Misses 4411 4413 +2 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 11, 2024
…to_identity_status_changes Fixes element-hq/element-meta#2566
andybalaam
force-pushed
the
andybalaam/sort-identity-status-changes
branch
from
4babfa5
to
bde2056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specific test for this case will need quite involved changes to
IdentityChangeDataSetso I am working on that as a separate change.Fixes element-hq/element-meta#2566