Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Change the behaviour when a duplicated event is received by the Timeline #3550

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix(ui): Change the behaviour when a duplicated event is received by the Timeline #3550

merged 2 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. fix(ui): Change the behaviour when a duplicated event is received by … 

    …`Timeline`.

This patch changes the behaviour of the `Timeline` when a duplicated
event is received. Prior to this patch, the old event was removed, and
the one was added. With this patch, the old event is kept, and the new
one is skipped.

This is important for matrix-org#3512
where events are mapped to the timeline item indices. When an event is
removed, it becomes difficult to keep the mapping correct.

This patch also adds duplication detection for pagination (with
`TimelineItemPosition::Start`).
    @Hywan
    Hywan committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    15ed91e View commit details
    Browse the repository at this point in the history

  2. chore(ui): Rename TimelineInnerState::add_event to `add_or_update_e… 

    …vent`.

This patch renames `add_event` to `add_or_update_event` because it is
what it does.
    @Hywan
    Hywan committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d46e658 View commit details
    Browse the repository at this point in the history