fix(ui): Change the behaviour when a duplicated event is received by the Timeline
#3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Timeline`. This patch changes the behaviour of the `Timeline` when a duplicated event is received. Prior to this patch, the old event was removed, and the one was added. With this patch, the old event is kept, and the new one is skipped. This is important for matrix-org#3512 where events are mapped to the timeline item indices. When an event is removed, it becomes difficult to keep the mapping correct. This patch also adds duplication detection for pagination (with `TimelineItemPosition::Start`).
Hywan
requested review from
poljar and
bnjbvr
and removed request for
a team and
poljar
bnjbvr
approved these changes
Jun 13, 2024
…vent`. This patch renames `add_event` to `add_or_update_event` because it is what it does.
|
We have many tests that play with duplicated events. Only one is breaking, the others are more high-level and we don't really see the result of this patch. However, if we try to remove the duplication check, or do it differently, many test will break. That's good. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
==========================================
- Coverage 83.84% 83.82% -0.03%
==========================================
Files 254 254
Lines 25842 25853 +11
==========================================
+ Hits 21668 21671 +3
- Misses 4174 4182 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the behaviour of the
Timelinewhen a duplicated event is received. Prior to this patch, the old event was removed, and the one was added. With this patch, the old event is kept, and the new one is skipped.This is important for #3512 where events are mapped to the timeline item indices. When an event is removed, it becomes difficult to keep the mapping correct.
This patch also adds duplication detection for pagination (with
TimelineItemPosition::Start).EventCachestorage #3280