chore(ui): Rewrite a bit TimelineEventHandler::add
#3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
requested review from
andybalaam and
bnjbvr
and removed request for
a team and
andybalaam
Hywan
force-pushed
the
chore-ui-timeline-event-handler-add
branch
from
08a6033
to
3d81cc4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
- Coverage 83.79% 83.77% -0.02%
==========================================
Files 254 254
Lines 25736 25743 +7
==========================================
+ Hits 21565 21566 +1
- Misses 4171 4177 +6 ☔ View full report in Codecov by Sentry. |
Hywan
force-pushed
the
chore-ui-timeline-event-handler-add
branch
from
3d81cc4
to
0d6f67e
Compare
bnjbvr
approved these changes
Jun 10, 2024
This patch renames `TimelineEventHandler::add` to `add_item`. This patch also removes the `should_add` argument. The `add_item` is called conditionally everytime. I believe this is much cleaner. Otherwise the method should have been called `maybe_add_item` with a return type or something that indicates whether the item is added. This patch makes it clear and remove one possible state in `add_item`.
Hywan
force-pushed
the
chore-ui-timeline-event-handler-add
branch
from
0d6f67e
to
17befab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames
TimelineEventHandler::addtoadd_item.This patch also removes the
should_addargument. Theadd_itemis called conditionally everytime. I believe this is much cleaner. Otherwise the method should have been calledmaybe_add_itemwith a return type or something that indicates whether the item is added. This patch makes it clear and remove one possible state inadd_item.RoomEventCache'sVectorDifftoTimeline#3512.EventCachestorage #3280.