Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix coverage uploads in separate workflow #3485

Merged
merged 6 commits into from
May 30, 2024
Merged

ci: Fix coverage uploads in separate workflow #3485

merged 6 commits into from
May 30, 2024

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented May 30, 2024 •
edited
Loading

Should start working after this merges. Second-to-last commit is the main fix, everything else is related refactorings.

@jplatte jplatte requested a review from a team as a code owner May 30, 2024 16:58
@jplatte jplatte requested review from Hywan and removed request for a team May 30, 2024 16:58
@jplatte jplatte changed the title ci: Fix coverage collection / uploading ci: Fix coverage uploads in separate workflow May 30, 2024
bnjbvr
bnjbvr approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time to fix this! Let's try it out.

@bnjbvr bnjbvr merged commit 9c4e547 into main May 30, 2024
36 checks passed
@bnjbvr bnjbvr deleted the jplatte/codecov-upload-dep-success branch May 30, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

@Hywan Hywan Awaiting requested review from Hywan Hywan is a code owner automatically assigned from matrix-org/rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplatte @bnjbvr