crypto: emit no identities_stream items on no-op changes
#3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update `ReadOnlyDevice::update_device` to return a bool indicating whether anything is changing.
There is no need to emit a notification from `identities_stream` when all devices are unchanged since last time.
richvdh
force-pushed
the
rav/no_device_update_on_unchanged
branch
from
a7e7436
to
2a605de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
==========================================
+ Coverage 83.23% 83.26% +0.02%
==========================================
Files 247 247
Lines 25051 25055 +4
==========================================
+ Hits 20851 20861 +10
+ Misses 4200 4194 -6 ☔ View full report in Codecov by Sentry. |
This was untested before, and it seems the coverage gate is now sad.
Hywan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: element-hq/element-web#27165.
Currently, whenever we receive a
/keys/queryresponse, we emit items fromidentities_stream_rawanddevices_streamfor any users listed in the response, even if there was no actual change to the devices. This PR changes behaviour so that items are only emitted if there are actual changes.