Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: add prompt param to auth url creation #3794

Merged
merged 3 commits into from
Oct 11, 2023
Merged

OIDC: add prompt param to auth url creation #3794

merged 3 commits into from
Oct 11, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Oct 9, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25393
With matrix-org/matrix-react-sdk#11727

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@kerryarchibald kerryarchibald mentioned this pull request Oct 9, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald marked this pull request as ready for review October 10, 2023 02:10
@kerryarchibald kerryarchibald requested a review from a team as a code owner October 10, 2023 02:10
florianduros
florianduros approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 11, 2023
Merged via the queue into develop with commit 1de6de0 Oct 11, 2023
18 checks passed
@kerryarchibald kerryarchibald deleted the kerry/25393/oidc-register branch October 11, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @florianduros