Fix minor typos #149
Merged
Fix minor typos #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only a couple don't fit, so try to combine things that are related in those cases.
timhoffm
reviewed
Feb 6, 2024
handout-beginner.tex
Outdated
| @@ -83,7 +83,7 @@ \section*{\LARGE \rmfamily | |||
| % | |||
| \fbox{2} \textbf{Prepare} | |||
| \begin{lstlisting} | |||
| X = np.linspace(0, 4*np.pi, 1000) | |||
| X = np.linspace(0.1, 10*np.pi, 1000) | |||
There was a problem hiding this comment.
I know you just adapted to the code. But why don't we start at 0? That'd be more intuitive.
There was a problem hiding this comment.
I think it leaves out 0 for the log scale one, but we can just create a new X/Y if we want 0 here.
- Use `C1` instead of `orange` to match other plots. - Remove extra plot in `sine-logscale.pdf`, which causes a bit of artifacting around the line. - Ensure text matches what is actually plotted for `markevery` settings; note I divided by 10 so that the text would fit in the block. Fixes matplotlib#133
I'm not sure what the tip in Performance section is supposed to do, but the slow part plots nothing, and the fast part doesn't run.
timhoffm
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spaces where possible. Fix
sine*plots examples to match code and text. Fix Performance tip which didn't run.