Simplify colormap plotting #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't know about the |
timhoffm
reviewed
Feb 6, 2024
All the special cases other than Greys are just the size of the colormap themselves, but we want to drop that special case as well. Also, colormaps are at most 256 elements long, so using `n=512` is probably not necessary.
This uses the same algorithm as the [Specifying colors tutorial](https://matplotlib.org/stable/users/explain/colors/colors.html#comparison-between-x11-css4-and-xkcd-colors).
QuLogic
force-pushed
the
simplify-colormap
branch
from
201b89f
to
61c26ab
Compare
... and debug a bit.
QuLogic
force-pushed
the
simplify-colormap
branch
from
6d23ed6
to
a5c2769
Compare
timhoffm
approved these changes
Feb 15, 2024
|
Do we have a one or two approval policy on the cheatsheets? |
rougier
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the special cases other than Greys are just the size of the colormap themselves. Also, colormaps are at most 256 elements long, so using
n=512is probably not necessary.Also, use the same algorithm as the Specifying colors tutorial to choose text colour over colour cycles.