Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Matplotlib 3.7.1 #125

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Bump to Matplotlib 3.7.1 #125

merged 1 commit into from
Feb 3, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 28, 2023

And also Cartopy to latest version to make it installable on current versions of Python.

Fixes #116
Fixes #124

@QuLogic QuLogic added the enhancement New feature or request label Mar 28, 2023
@QuLogic QuLogic marked this pull request as draft March 28, 2023 08:47
@QuLogic
Copy link
Member Author

QuLogic commented Mar 28, 2023

Possible things to investigate after finishing the build locally:

  • Beginners:
    • Edges around scatter, bar, pie, hist, and boxplot are not exactly the same size
  • Intermediate:
    • Edges around anatomy circles are missing
    • Sine and Cosine figure appears to be a bit taller
  • Tips:
    • Random data in transparency section seems completely different

Some similar problems occur in the 2-page version.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 28, 2023

Also note that the anatomy example has changed somewhat in Matplotlib: https://github.com/matplotlib/matplotlib/compare/v3.5.0..v3.7.1#diff-d476362ab30b16055b90f54100d51a2d0e479f1f886bbf371f2008f734bb9ef8; not sure if we want to bring those changes over here.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 28, 2023

Looking at the results from the build:

  • On cheatsheets p1, seaborn-notebook -> seaborn-v0_8-notebook is a little too wide, but still visible. cheatsheets-1-diff
  • On cheatsheets p2, the Axes in the imshow example, Image Interpolation section, and Annotation connection styles section are now compressed closer. cheatsheets-2-diff
  • On the intermediate handout, there are minor shifts because the Sine and Cosine figure is a little bit taller. handout-intermediate-diff
  • On the tips-and-tricks handout, the random results in the Transparency section have changed; it doesn't appear to have a seed. handout-tips-diff

Please ignore all my previous comments about local differences, as they appear to be local to my machine and not specific to this change.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 28, 2023

Also, looking at the build a bit closer, it appears that figures/legend.pdf changed because it was re-cropped, but that's not a real change, so I will revert that.

@QuLogic QuLogic force-pushed the mpl37 branch 2 times, most recently from 063cb83 to ea45a56 Compare March 29, 2023 00:49
@QuLogic
Copy link
Member Author

QuLogic commented Mar 29, 2023

With #126 in, the tip-and-tricks diff is now:
handout-tips-diff

@QuLogic QuLogic marked this pull request as ready for review March 29, 2023 01:22
@QuLogic
Copy link
Member Author

QuLogic commented Mar 29, 2023

IIRC, we stopped counting invisible ticks in tight layout at some point, which is likely the reason the Axes were clipped closer, and thus appear a bit bigger now.

And also Cartopy to latest version to make it installable on current
versions of Python.
@QuLogic
Copy link
Member Author

QuLogic commented Feb 1, 2024

Rebased, but note the above comment: #125 (comment)

@timhoffm
Copy link
Member

timhoffm commented Feb 1, 2024

Rebased, but note the above comment: #125 (comment)

Theoretically yes. But that doesn't have to be within this PR. And please check whether it's still readable - if I see it correctly, we have added more content.

@dstansby dstansby merged commit 05d47a5 into matplotlib:master Feb 3, 2024
3 checks passed
@QuLogic QuLogic deleted the mpl37 branch February 6, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cartopy version Update for 3.6.0
3 participants