Allow customization of rollout strategies for deployments #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
reviewed
Jul 10, 2024
templates/deployment-sidekiq.yaml
Outdated
| exec: | ||
| command: | ||
| - cat | ||
| - /var/www/tmp/sidekiq_process_has_started_and_will_begin_processing_jobs |
There was a problem hiding this comment.
I think the path is /opt/mastodon/tmp/sidekiq_process_has_started_and_will_begin_processing_jobs in our containers?
There was a problem hiding this comment.
Also mastodon/mastodon#30988 allows people to change the filename for this. I do not know why someone would do it, but it will become possible. Our default Dockerfile sets it to the name above.
There was a problem hiding this comment.
Ah this was the path given to me earlier. I'll change it.
And yeah, if it can be customized elsewhere, it should be customizable here too.
renchap
reviewed
Jul 10, 2024
renchap
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.