Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plugin is compatible #1327

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix plugin is compatible #1327

merged 1 commit into from
Jan 23, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 22, 2024

Bug

I want to install the wallet plugin but it not possible and there is a warning saying that it requires version 0.3.0 of massa station, I run version 0.6.1 of massa station.

Fix

This bug is introdoced in version 0.6.1, it was working well in 0.6.0. This PR introduce the bug: #1316

The fix is to rename the variable isCompatible.

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof merged commit 575fd4b into main Jan 23, 2024
15 checks passed
@Thykof Thykof deleted the fix-plugin-is-compatible branch January 23, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants