Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page ui fixes #947

Merged
merged 6 commits into from
May 24, 2024
Merged

Home page ui fixes #947

merged 6 commits into from
May 24, 2024

Conversation

pivilartisant
Copy link
Contributor

@pivilartisant pivilartisant commented May 22, 2024

We are fixing new mns feature to add QA feedback:

  • down case D in "Domains"
  • Truncate part of the dns list for better ux (user must understand they can scroll)
  • Align right address and mns in confirmation page
  • Reduce tooltip size

@pivilartisant pivilartisant requested review from Thykof and thomas-senechal and removed request for Thykof May 22, 2024 14:21
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Hook useEffect has a missing dependency: 'resetDomainList'. Either include it or remove the dependency array

you hard code the px size, are you sure it's a good idea? I know the app is not responsive...

@pivilartisant
Copy link
Contributor Author

pivilartisant commented May 22, 2024

React Hook useEffect has a missing dependency: 'resetDomainList'. Either include it or remove the dependency array

you hard code the px size, are you sure it's a good idea? I know the app is not responsive...

I changed the tooltip, no more hardcoded px... instead we use html with the: br tag

@pivilartisant pivilartisant requested a review from Thykof May 22, 2024 15:10
@pivilartisant
Copy link
Contributor Author

pivilartisant commented May 22, 2024

React Hook useEffect has a missing dependency: 'resetDomainList'. Either include it or remove the dependency array

Adding this dependency causes infinite re-renders... i will try to find another option

@peterjah peterjah merged commit 9ce5ab3 into main May 24, 2024
16 checks passed
@peterjah peterjah deleted the add-mns-qa-fixes branch May 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants