Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention that that Rust 1.76 is required to install from source #4677

Merged
merged 1 commit into from
Oct 19, 2024
Merged

docs: mention that that Rust 1.76 is required to install from source #4677

merged 1 commit into from
Oct 19, 2024

Conversation

martinvonz
Copy link
Owner

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

jrn
jrn approved these changes Oct 19, 2024
View reviewed changes
Copy link

@jrn jrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good. Thank you!

docs/install-and-setup.md Outdated Show resolved Hide resolved
@martinvonz
docs: mention that that Rust 1.76 is required to install from source
4d6918b 
We have our MSRV recorded in `Cargo.toml`, but at least with Rust
versions < 1.71, the build fails before the MSRV is checked (IIUC),
and you get a cryptic message like this:

```
error: Package jj-lib v0.22.0 (<some path>) does not have feature git2.
```

The message is clearer from 1.71, but that doesn't help users who have
an older version. Let's mention the MSRV everywhere we tell the user
to run `cargo` in the installation instructions.
@martinvonz martinvonz enabled auto-merge (rebase) October 19, 2024 22:46
@martinvonz martinvonz merged commit e00f6f1 into main Oct 19, 2024
31 checks passed
@martinvonz martinvonz deleted the push-lolmlournmvs branch October 19, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrn jrn jrn approved these changes

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvonz @jrn @PhilipMetzger