nix: only use rust-src in devShell toolchain
#4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thoughtpolice In the meantime, I've opened #4676 which fixes a build failure (with the current flake) on the latest nixpkgs. |
See the included comment. This helps avoid a large dependency on the rustc toolchain and helps reduce closure size for Nix users. Partial revert of 749481e. Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-tqtlpunypqln
branch
from
c7b6f72
to
20f0f2f
Compare
thoughtpolice
changed the title
rust-src in devShell
Ralith
approved these changes
Oct 22, 2024
thoughtpolice
changed the title
rust-src in devShellrust-src in devShell toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by EsperLily in Discord.
My personal machine is seeing strange testsuite failures, so I'm posting this just to see how the CI goes.