tests: umockdev-record: t_system_single: handle missing SELinux context on /dev/null #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
requested changes
Oct 30, 2024
…xt on /dev/null /sys/fs/selinux might exist, yet the checked path might have no context defined. Drop the check for the selinux pseudo-fs, and check the eventual errno if lgetfilecon() fails. On ENODATA (context doesn't exist, or the process can't access it), ENOTSUP (extended attributes not supported/disabled) and ENOSYS (lgetxattr syscall used by lgetfilecon() not available), ensure __DEVCONTEXT is not there and continue. On every other error, fail the test case as before. Signed-off-by: Eugenio Paolantonio <[email protected]>
g7
force-pushed
the
test-umockdev-record-selinux
branch
from
edf2d52
to
28f5365
Compare
g7
changed the title
|
v2:
|
martinpitt
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Thanks! The gentoo error is unrelated, it already started a month ago. I'll look at that separately.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Sorry, let's discuss that Gentoo issue in PR #257 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sys/fs/selinux might exist, yet the checked path might have no
context defined.
Drop the check for the selinux pseudo-fs, and check the eventual
errno if lgetfilecon() fails.
On ENODATA (context doesn't exist, or the process can't access it),
ENOTSUP (extended attributes not supported/disabled) and ENOSYS
(lgetxattr syscall used by lgetfilecon() not available), ensure
__DEVCONTEXT is not there and continue.
On every other error, fail the test case as before.