feat: generate martian struct field descriptions and filenames #574
Annotations
11 warnings
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: 10XGenomics/clippy-check@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run 10XGenomics/clippy-check@main:
martian/src/mro.rs#L36
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:36:17
|
36 | / assert!(
37 | | width >= min_width,
38 | | "Need a minimum width of {}. Found {}",
39 | | min_width,
40 | | width
41 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: requested on the command line with `-W clippy::uninlined-format-args`
|
|
Run 10XGenomics/clippy-check@main:
martian/src/mro.rs#L113
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:113:13
|
113 | writeln!(f, " {},", formatted_line)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
113 - writeln!(f, " {},", formatted_line)?;
113 + writeln!(f, " {formatted_line},")?;
|
|
|
Run 10XGenomics/clippy-check@main:
martian/src/mro.rs#L485
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:485:31
|
485 | Some(ref desc) => format!(" \"{}\"", desc),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
485 - Some(ref desc) => format!(" \"{}\"", desc),
485 + Some(ref desc) => format!(" \"{desc}\""),
|
|
|
Run 10XGenomics/clippy-check@main:
martian/src/mro.rs#L489
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:489:31
|
489 | Some(ref name) => format!(" \"{}\"", name),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
489 - Some(ref name) => format!(" \"{}\"", name),
489 + Some(ref name) => format!(" \"{name}\""),
|
|
|
Run 10XGenomics/clippy-check@main:
martian/src/mro.rs#L530
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:530:13
|
530 | / assert!(
531 | | self.name != token,
532 | | "Martian token {} cannot be used as field name",
533 | | token
534 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
Run 10XGenomics/clippy-check@main:
martian/src/mro.rs#L930
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:930:13
|
930 | / write!(
931 | | f,
932 | | "{params:<ty_width$}",
933 | | params = chunk_in_out,
934 | | ty_width = ty_width
935 | | )?;
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
Run 10XGenomics/clippy-check@main:
martian/src/lib.rs#L360
warning: variables can be used directly in the `format!` string
--> martian/src/lib.rs:360:9
|
360 | / assert!(
361 | | header_comment
362 | | .lines()
363 | | .all(|line| line.trim_end().is_empty() || line.starts_with('#')),
364 | | "All non-empty header lines must start with '#', but got\n{}",
365 | | header_comment
366 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
Run 10XGenomics/clippy-check@main:
martian-derive/src/lib.rs#L327
warning: variables can be used directly in the `format!` string
--> martian-derive/src/lib.rs:327:9
|
327 | / format!(
328 | | "{}. You are trying to use it on {} trait implementation.",
329 | | ATTR_NOT_ON_TRAIT_IMPL_ERROR, last_ident
330 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: requested on the command line with `-W clippy::uninlined-format-args`
|
|
Run 10XGenomics/clippy-check@main:
martian-derive/src/lib.rs#L550
warning: variables can be used directly in the `format!` string
--> martian-derive/src/lib.rs:550:17
|
550 | / format!(
551 | | "Field name {} is not allowed here since it is a martian keyword",
552 | | name
553 | | ),
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
Run 10XGenomics/clippy-check@main:
martian-derive/src/lib.rs#L565
warning: variables can be used directly in the `format!` string
--> martian-derive/src/lib.rs:565:19
|
565 | let err = format!("ERROR: force_filename attribute was specified for field '{name}' but a doc comment was not defined for the field. \
| ___________________^
566 | | force_filename can only be specified when a doc comment is specified for a field, \
567 | | because doc comments are converted into Martian struct field descriptions which precede the Martian filename column (optional 3rd and 4th columns in Martian struct def)", name = nam...
| |_______________________________________________________________________________________________________________________________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
565 ~ let err = format!("ERROR: force_filename attribute was specified for field '{name}' but a doc comment was not defined for the field. \
566 | force_filename can only be specified when a doc comment is specified for a field, \
567 ~ because doc comments are converted into Martian struct field descriptions which precede the Martian filename column (optional 3rd and 4th columns in Martian struct def)");
|
|
Loading