Skip to content

feat: thread shared metadata file into rover to enable use of alarm #456

feat: thread shared metadata file into rover to enable use of alarm

feat: thread shared metadata file into rover to enable use of alarm #456

Triggered via pull request July 22, 2023 01:00
Status Failure
Total duration 1m 4s
Artifacts

clippy.yml

on: pull_request
clippy_check
56s
clippy_check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 7 warnings
redundant clone: martian-derive/src/lib.rs#L155
error: redundant clone --> martian-derive/src/lib.rs:155:41 | 155 | let stage_struct = item_impl.self_ty.clone(); | ^^^^^^^^ help: remove this | note: cloned value is neither consumed nor mutated --> martian-derive/src/lib.rs:155:24 | 155 | let stage_struct = item_impl.self_ty.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `-D clippy::redundant-clone` implied by `-D clippy::perf`
clippy_check
Clippy had exited with the 101 exit code
variables can be used directly in the `format!` string: martian/src/mro.rs#L36
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:36:17 | 36 | / assert!( 37 | | width >= min_width, 38 | | "Need a minimum width of {}. Found {}", 39 | | min_width, 40 | | width 41 | | ); | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args`
variables can be used directly in the `format!` string: martian/src/mro.rs#L444
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:444:13 | 444 | / assert!( 445 | | self.name != token, 446 | | "Martian token {} cannot be used as field name", 447 | | token 448 | | ); | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian/src/mro.rs#L847
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:847:13 | 847 | / write!( 848 | | f, 849 | | "{params:<ty_width$}", 850 | | params = chunk_in_out, 851 | | ty_width = ty_width 852 | | )?; | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian/src/lib.rs#L360
warning: variables can be used directly in the `format!` string --> martian/src/lib.rs:360:9 | 360 | / assert!( 361 | | header_comment 362 | | .lines() 363 | | .all(|line| line.trim_end().is_empty() || line.starts_with('#')), 364 | | "All non-empty header lines must start with '#', but got\n{}", 365 | | header_comment 366 | | ); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L325
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:325:9 | 325 | / format!( 326 | | "{}. You are trying to use it on {} trait implementation.", 327 | | ATTR_NOT_ON_TRAIT_IMPL_ERROR, last_ident 328 | | ), | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args`
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L488
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:488:45 | 488 | / ... format!( 489 | | ... "{}. Found {}", 490 | | ... INVALID_MRO_TYPE_ERROR, val_string 491 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L520
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:520:17 | 520 | / format!( 521 | | "Field name {} is not allowed here since it is a martian keyword", 522 | | name 523 | | ), | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args