Remove min Python 3 minor version in docs and README #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloria
approved these changes
Oct 17, 2024
docs/upgrading.rst
Outdated
| @@ -62,7 +62,7 @@ Upgrading to 3.0 | |||
| Python compatibility | |||
| ******************** | |||
|
|
|||
| The marshmallow 3.x series supports Python >= 3.8. | |||
| The marshmallow 3.x series require Python 3. | |||
There was a problem hiding this comment.
Suggested change
| The marshmallow 3.x series require Python 3. | |
| The marshmallow 3.x series requires Python 3. |
There was a problem hiding this comment.
Oh right. Series is singular here...
There was a problem hiding this comment.
Shouldn't I remove the whole Python 3 mention, in 2024?
There was a problem hiding this comment.
Oh, no, that's the upgrading to 3.0.0 section. Leaving it for history.
However, I'm tempted to also remove the Requirements section of the README.
There was a problem hiding this comment.
remove the Requirements section of the README.
👍
lafrech
changed the title
sloria
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to update those before releasing and it might not be the first time.
What about we remove the mention of the minor version from the doc pages?
I'd be tempted to also remove it from the README. Especially since we support all maintained Python versions anyway.