Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x #371

Merged
merged 5 commits into from
Sep 29, 2023
Merged

5.x #371

merged 5 commits into from
Sep 29, 2023

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Sep 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0dbf340) 92.39% compared to head (90fb267) 92.39%.
Report is 4 commits behind head on 5.x.

❗ Current head 90fb267 differs from pull request most recent head 68b26ea. Consider uploading reports for the commit 68b26ea to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                5.x     #371      +/-   ##
============================================
- Coverage     92.39%   92.39%   -0.01%     
  Complexity      116      116              
============================================
  Files            10       10              
  Lines           342      368      +26     
============================================
+ Hits            316      340      +24     
- Misses           26       28       +2     
Files Coverage Δ
src/View/Helper/AssetCompressHelper.php 89.76% <100.00%> (-1.44%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -18,13 +18,13 @@
},
"require": {
"php": ">=8.1.0",
"cakephp/cakephp": "5.x-dev",
"cakephp/cakephp": "^5.0",
"markstory/mini-asset": "2.x-dev",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to take care of this 🙂

@markstory markstory merged commit 082dabd into markstory:5.x Sep 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants