-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction of Issue #83 #109
Conversation
@yunzvanessa I added this pull request as you asked for Regards |
Hi Diego, Thanks for your timely reply! Sorry for the confusion, but I think another correction is needed if it's okay for you. When creating a new pull request, you want to merge into marklogic remote branch from the same local branch. In your case, you may want to checkout Please let me know if you have questions. Thanks, |
Hi Vanessa:
Thanks for the clarification, I created a pull request from develop branch
to origin/branch :-) .
Let me know if you have any questions or comments about it.
Kind regards.
Diego Arturo Barriguete
<http://crimsonplace.blogspot.com>
…On Mon, Aug 26, 2019 at 1:55 PM Vanessa Zhang ***@***.***> wrote:
Hi Diego,
Thanks for your timely reply!
Sorry for the confusion, but I think another correction is needed if it's
okay for you. When creating a new pull request, you want to merge into
marklogic remote branch from the same local branch. In your case, you may
want to checkout develop branch to your local repo (command: git checkout
-b develop origin/develop), commit and push your fix and create a new
pull request from your develop branch to merge into marklogic:develop.
Please let me know if you have questions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=AMDGFUMCRLTQZUIJLC5TQTDQGQRK7A5CNFSM4IPSHNGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FKCGI#issuecomment-524984601>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMDGFUNZ2EMUOAX2KXTQLCDQGQRK7ANCNFSM4IPSHNGA>
.
|
This pull request contains the code to solve issue #83 (#83)
Thanks in advance for your attention.
Regards
Diego