Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure devcontainer.json with hugomods/hugo #344

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Configure devcontainer.json with hugomods/hugo #344

merged 3 commits into from
Oct 14, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Oct 14, 2024

Use image with more up-to-date Hugo version than default image for dev container.

https://docker.hugomods.com/

@louwers louwers changed the title Create devcontainer.json with hugomods/hugo Configure devcontainer.json with hugomods/hugo Oct 14, 2024
@louwers louwers requested a review from HarelM October 14, 2024 12:22
@louwers louwers requested a review from HarelM October 14, 2024 12:24
@HarelM
Copy link
Collaborator

HarelM commented Oct 14, 2024

Are you able to run a docker command to serve the hugo site using docker?

@HarelM
Copy link
Collaborator

HarelM commented Oct 14, 2024

Can you update the readme to allow running the site with only docker installed?

@louwers
Copy link
Collaborator Author

louwers commented Oct 14, 2024

Yes it works.

Docker?

You can just run

npm install
hugo serve

once the devcontainer starts

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approved although I would still recommend improving the readme on how to use docker instead of the need to install locally the relevant version.

@louwers
Copy link
Collaborator Author

louwers commented Oct 14, 2024

That's a separate issue I think.

@louwers
Copy link
Collaborator Author

louwers commented Oct 14, 2024

I can add a Dockerfile.

@HarelM
Copy link
Collaborator

HarelM commented Oct 14, 2024

I was not able to make it work using the docker command in the documentation, so I'm less optimistic than you are I guess...
Your call, I have little patience to this repo and the way things are maintained here...

@HarelM
Copy link
Collaborator

HarelM commented Oct 14, 2024

I don't think a dockerfile is needed as you don't need to publish a docker image, just run the docker locally to avoid the need to install hugo.
A simple docket run --rm -v... Should do, but it didn't work for me, so IDK...

@HarelM
Copy link
Collaborator

HarelM commented Oct 14, 2024

I'll merge this, at least see if I can make the site run...

@HarelM HarelM merged commit ae6bf7b into main Oct 14, 2024
1 check passed
@HarelM HarelM deleted the devcontainer branch October 14, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants