Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchup syntax in proto for readibility #108

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

springmeyer
Copy link
Collaborator

While reviewing the .proto I noticed a few minor things that could be improved for future readers:

  • Cleanup mixed tabs & spaces (now uses only spaces)
  • Consistently using a space before {
  • Consistently commenting code above the line it references (rather than both above and to the right)
  • Consistently using a space after a commented line with //

In addition to this basic cleanup I think further linting is advisable: #107

While reviewing the .proto I notice a few minor things that could be
improved for future readers:

 - Cleanup mixed tabs & spaces (only spaces)
 - Consistently space before ` {`
 - Consistently commenting code above the line it references
@springmeyer springmeyer merged commit 4b92e98 into maplibre:main Jun 10, 2024
6 checks passed
@springmeyer springmeyer deleted the dane/proto-cleanup branch June 10, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants