Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example that communicates directly with a Valhalla backend #119

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Example that communicates directly with a Valhalla backend #119

merged 10 commits into from
Sep 25, 2024

Conversation

eikes
Copy link
Contributor

@eikes eikes commented Sep 23, 2024

No description provided.

@eikes eikes marked this pull request as ready for review September 23, 2024 22:08
Fabi755
Fabi755 requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Fabi755 Fabi755 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and works well.

I see many improvements, but this also applies to the other examples. That should not be your problem.

But the configuration generation should be changed. And please add an entry to the CHANGELOG.md file.

Thanks a lot!

...c/main/java/com/mapbox/services/android/navigation/testapp/ValhallaMockNavigationActivity.kt Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Fabi755 Fabi755 mentioned this pull request Sep 23, 2024
Open
@eikes eikes requested a review from Fabi755 September 24, 2024 10:24
@Fabi755 Fabi755 merged commit d41a831 into maplibre:main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankkienl frankkienl frankkienl left review comments

@Fabi755 Fabi755 Fabi755 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eikes @frankkienl @Fabi755