-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setVerticalFieldOfView() to public API #4914
Conversation
@wipfli I think you were asking about this at the last MapLibre-GL-JS meeting? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4914 +/- ##
==========================================
+ Coverage 90.49% 90.66% +0.17%
==========================================
Files 265 265
Lines 38103 38113 +10
Branches 3181 3150 -31
==========================================
+ Hits 34482 34557 +75
+ Misses 2674 2599 -75
- Partials 947 957 +10 ☔ View full report in Codecov by Sentry. |
I'm not sure how comfortable I am with exposing this. Can we gather more feedback on this? |
@louwers can this be changed in the Android or native code? I've seen some mapbox old docs that reference this I think. |
@HarelM MapLibre Native has a hardcoded fov. |
Thanks for sharing! Does this work as well for terrain3d and globe? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this won't bite is in the future...
Launch Checklist
This PR adds
setVerticalFieldOfView()
to the public API. This allows different camera focal length to be used, like this:set_fov.mp4
This is useful for applications that control the camera position: #4717
CHANGELOG.md
under the## main
section.