-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't suppress useful errors #4912
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4912 +/- ##
===========================================
- Coverage 89.94% 71.78% -18.17%
===========================================
Files 265 265
Lines 37977 37982 +5
Branches 2529 2190 -339
===========================================
- Hits 34159 27265 -6894
- Misses 2951 9459 +6508
- Partials 867 1258 +391 ☔ View full report in Codecov by Sentry. |
I think we should only catch abort error, see the following issue as well: |
When doing that I discovered that we were swallowing some errors when running unit tests. I'll move this PR to draft mode and ping you back when I got those fixed |
This might also be relevant to this issue (hopefully fix it?): The following PR is an attempt to fix this I believe: The following PR is the migration of the actor from callback to promises, which also changed the frame and abort errors to use abort controller and what probably started all this issue: |
This PR avoids suppressing any error that's not an abort error.
We were swallowing all of them and I found difficult to debug GLSL shaders with that happening.
Fixes #4532
Launch Checklist
CHANGELOG.md
under the## main
section.