Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounting for IDs of cluster features when the promoteID properties is set #4899

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −0
Draft

Accounting for IDs of cluster features when the promoteID properties is set #4899

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e41b37
Accounting for IDs of cluster features when the promoteID properties …
popkinj Oct 25, 2024
5e82463
Merge branch 'main' into main
popkinj Oct 25, 2024
4ce3f32
Merge branch 'main' into main
popkinj Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/data/feature_index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,11 @@ export class FeatureIndex {
const propName = typeof this.promoteId === 'string' ? this.promoteId : this.promoteId[sourceLayerId];
id = feature.properties[propName] as string | number;
if (typeof id === 'boolean') id = Number(id);

// When cluster is true, the id is the cluster_id even though promoteId is set
if (id === undefined && feature.properties?.cluster && this.promoteId) {
id = Number(feature.properties.cluster_id);
}
}
return id;
}
Expand Down