Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabindex when non-interactive map #12852

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kumilange
Copy link
Contributor

@kumilange kumilange commented Aug 15, 2023

Handling the good first issue #12822, removing tabindex attribute when map is set as non-interactive.

[Before]
before

[After]
after

Note about Attribution

Since Attribution which has links and is tabbable seems to be a must to have on map, its behavior is still kept as it is like this: http://g.recordit.co/ET7dF5c9Ny.gif

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • manually test the debug page
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Remove tabindex attribute when map is non-interactive</changelog>

closes #12822

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @kumiko-haraguchi

Thanks for the contribution, it looks good to me 👍

@stepankuzmin stepankuzmin marked this pull request as ready for review August 17, 2023 09:30
@stepankuzmin stepankuzmin requested a review from a team as a code owner August 17, 2023 09:30
@stepankuzmin stepankuzmin merged commit 1ecb7a9 into mapbox:main Sep 12, 2023
3 checks passed
@kumilange kumilange deleted the rm-tabindex-noninteractive branch February 29, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-interactive maps should not have a tabindex
3 participants