Don't call onDrag when multiple fingers are touching the map #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling onDrag when multiple fingers are touching the map causes a delay when you start pinch zooming. This is because the pinch is interpreted as a tap in the beginning, which causes stopPropagation to be called. I think dragging is an action you only do with one finger, so therefore I think not calling onDrag is the correct solution to this. Fixes mapbox#962
aptroost
approved these changes
Apr 2, 2020
|
I've used this approach in my own fork to avoid wrecking a shape that's in direct_select mode while pinch-zooming on a mobile device. I'm finding editing on mobile to be pretty impossible without that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling onDrag when multiple fingers are touching the map causes a delay
when you start pinch zooming. This is because the pinch is interpreted
as a tap in the beginning, which causes stopPropagation to be called.
I think dragging is an action you only do with one finger, so therefore
I think not calling onDrag is the correct solution to this.
I'm not sure how to test this, as I haven't figured out how to check if events are called. Are there any existing tests doing such checks?
Fixes #962