-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace tqdm, termcolor, tabulate with rich #2374
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
41e2223
logging: use rich handler for logging
fariss 6669a62
tqdm: remove unneeded redirecting_print_to_tqdm function
fariss ada9246
tqdm: introduce `CapaProgressBar` rich `Progress` bar
fariss 727e657
tqdm: replace tqdm with rich Progress bar
fariss a800698
tqdm: remove tqdm dependency
fariss 6a3d4e7
termcolor: replace termcolor and update `scripts/`
fariss 6abe18b
tests: update `test_render.py` to use rich.console.Console
fariss 807b215
termcolor: remove termcolor dependency
fariss c0a6ab9
capa.render.utils: add `write` & `writeln` methods to subclass `Console`
fariss 75b675c
update markup util functions to use fmt strings
fariss 13c37ae
tests: update `test_render.py` to use `capa.render.utils.Console`
fariss c28a6b6
replace kwarg `end=""` with `write` and `writeln` methods
fariss dd41874
tabulate: replace tabulate with `rich.table`
fariss 688869a
tabulate: remove `tabulate` and its dependency `wcwidth`
fariss 2218db7
logging: handle logging in `capa.main`
fariss 95e806a
logging: set up logging in `capa.main`
fariss 5770ade
changelog: replace packages with rich
fariss 1024c49
remove entry from pyinstaller and unneeded progress.update call
fariss 4b91652
update requirements.txt
fariss 596a5bb
scripts: use `capa.helpers.log_console` in `CapaProgressBar`
fariss 33249f5
logging: configure root logger to use `RichHandler`
fariss b9e5841
remove unused import `inspect`
fariss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
[mypy] | ||
|
||
[mypy-tqdm.*] | ||
ignore_missing_imports = True | ||
|
||
[mypy-ruamel.*] | ||
ignore_missing_imports = True | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merge we'll have to test and ensure the new implementation also works under Ghidra, which has some weird restrictions.