Skip to content

Commit

Permalink
tests: xfail binja forwarded exports
Browse files Browse the repository at this point in the history
  • Loading branch information
williballenthin committed Jul 17, 2023
1 parent d1f5a6e commit 221a5a9
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,5 @@ Pipfile
Pipfile.lock
/cache/
.github/binja/binaryninja
.github/binja/download_headless.py
.github/binja/BinaryNinja-headless.zip
2 changes: 1 addition & 1 deletion capa/features/extractors/viv/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import capa.features.extractors.common
import capa.features.extractors.helpers
import capa.features.extractors.strings
from capa.features.file import Export, FunctionName, Import, Section
from capa.features.file import Export, Import, Section, FunctionName
from capa.features.common import Feature, Characteristic
from capa.features.address import Address, FileOffsetAddress, AbsoluteVirtualAddress

Expand Down
9 changes: 9 additions & 0 deletions tests/test_binja_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import fixtures

import capa.main
import capa.features.file
import capa.features.common

logger = logging.getLogger(__file__)

Expand Down Expand Up @@ -40,6 +42,13 @@
def test_binja_features(sample, scope, feature, expected):
if feature == capa.features.common.Characteristic("stack string"):
pytest.xfail("skip failing Binja stack string detection temporarily, see #1473")

if isinstance(feature, capa.features.file.Export) and "." in str(feature.value):
pytest.xfail("skip Binja unsupported forwarded export feature, see #1624")

if feature == capa.features.common.Characteristic("forwarded export"):
pytest.xfail("skip Binja unsupported forwarded export feature, see #1624")

fixtures.do_test_feature_presence(fixtures.get_binja_extractor, sample, scope, feature, expected)


Expand Down

0 comments on commit 221a5a9

Please sign in to comment.