Ignore missing info/files file
#671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beenje
reviewed
Nov 21, 2023
quetz/condainfo.py
Outdated
| try: | ||
| with tar.extractfile("info/files") as fp: | ||
| self.files = fp.readlines() | ||
| except: |
There was a problem hiding this comment.
Suggestion:
Suggested change
| except: | |
| except KeyError: |
wolfv
added
enhancement
|
Tested that change locally. I uploaded a package created by rattler-build without issue. Could install it with mamba afterwards. Looks good to me. Thanks! |
pavelzw
approved these changes
Nov 21, 2023
janjagusch
changed the title
info/files fileinfo/files file
|
Available on dockerhub now |
beenje
added a commit
to beenje/quetz
that referenced
this pull request
Oct 10, 2024
File not created by rattler-build. See mamba-org#671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @beenje do you think you could deploy a change like this?