Skip to content

Commit

Permalink
Upgraded LLVM
Browse files Browse the repository at this point in the history
  • Loading branch information
malkia committed Jul 2, 2024
1 parent 2a0621e commit ef820be
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/otel_sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
steps:
- run: systeminfo
- run: Get-ChildItem env:* | Sort-Object -Property Name | Format-Table -AutoSize
- run: choco upgrade llvm --version 18.1.6
- run: winget upgrade LLVM.LLVM --version 18.1.8 --silent
- uses: actions/checkout@v4
- uses: actions/cache/restore@v4
with:
Expand Down
7 changes: 7 additions & 0 deletions bazel/otel_cc.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ load("@rules_cc//cc:defs.bzl",
)

def otel_cc_library(**kwargs):
# dump = kwargs["name"] + ": "
# dump = dump + " mod=" + native.module_name()
# dump = dump + " ver=" + native.module_version()
# dump = dump + " pkg=" + native.package_name()
# dump = dump + " repo=" + native.repo_name()
# print(dump)

# Link as .o (.obj) files, not .a (.lib)
kwargs["alwayslink"] = kwargs.get("alwayslink", True)

Expand Down
6 changes: 4 additions & 2 deletions bazel/otel_cc_benchmark.bzl
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Copyright The OpenTelemetry Authors
# SPDX-License-Identifier: Apache-2.0

load("otel_cc.bzl", "otel_cc_binary", "otel_cc_test")

def otel_cc_benchmark(name, srcs, deps, tags = [""]):
"""
Creates targets for the benchmark and related targets.
Expand All @@ -22,7 +24,7 @@ def otel_cc_benchmark(name, srcs, deps, tags = [""]):

# This is the benchmark as a binary, it can be run manually, and is used
# to generate the _result below.
native.cc_binary(
otel_cc_binary(
name = name,
srcs = srcs,
deps = deps + ["@google_benchmark//:benchmark"],
Expand All @@ -41,7 +43,7 @@ def otel_cc_benchmark(name, srcs, deps, tags = [""]):

# This is run as part of "bazel test ..." to smoke-test benchmarks. It's
# meant to complete quickly rather than get accurate results.
native.cc_test(
otel_cc_test(
name = name + "_smoketest",
srcs = srcs,
deps = deps + ["@google_benchmark//:benchmark"],
Expand Down

0 comments on commit ef820be

Please sign in to comment.