Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(foundry-vtt): bad annotations indentation in ingress template #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(foundry-vtt): bad annotations indentation in ingress template #32

wants to merge 1 commit into from

Conversation

Mareo
Copy link
Contributor

@Mareo Mareo commented Oct 16, 2024

This PR fixes annotations indentation in the ingress template, adding more than one ingress.annotations triggers the bug:

$ helm template --repo https://helm.mahahe.it/ foundry-vtt --set ingress.enabled=true,ingress.annotations.test1=test,ingress.annotations.test2=test --show-only templates/ingress.yaml --debug

@Mareo Mareo requested a review from a team as a code owner October 16, 2024 12:42
@Mareo Mareo requested review from matteob99 and removed request for a team October 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteob99 matteob99 Awaiting requested review from matteob99 matteob99 is a code owner automatically assigned from mahahe-it/sysadmins

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mareo